search

dunnkers / ember-polymer

Use Polymer in your ambitious Ember application! 💎
https://dunnkers.github.io/ember-polymer/
MIT License
21 stars 6 forks source link

Fix addon 🙌🏻 #60

Closed dunnkers closed 7 years ago

dunnkers commented 7 years ago

The update update-dependencies branch went through different cycles of trying to fix the addon caused by https://github.com/glimmerjs/glimmer-vm/issues/453. The issue was eventually fixed by a patch release (https://github.com/glimmerjs/glimmer-vm/pull/529) in ember v2.13.3 💪🏻

Eventually, in upgrading the addon I also changed baseURL to rootURL, deprecated way back in Ember 2.7. This caused another issue (#57) but was fixed in 0d9691d.

Then lastly, the addon was suffering random test failures, traced down to issue https://github.com/dunnkers/ember-polymer/issues/59, describing that PhantomJS caused this. However, simply including all polyfills instead of just the lite (fb52b07 ) seems to have fixed the problem. Hurray 👐🏻

Time for a v1.0! 😻

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.802% when pulling fb52b071c21b65e03654e51a3c3be03e4b5fcf9d on update-dependencies into 5806a5bacd67d5f7f33c0c53d9ef0db4cf525680 on master.