search

dunnock / react-sigma

Lightweight React library for drawing network graphs built on top of SigmaJS
https://dunnock.github.io/react-sigma/
MIT License
258 stars 43 forks source link

DragNodes component, wrapping the sigma.plugins.dragNodes plugin. #93

Closed jvkersch closed 4 years ago

jvkersch commented 4 years ago

This is a small component, wrapping the sigma.plugins.dragNodes plugin.

Comments welcome -- this is my first React PR, happy to add tests, docs, etc.

dunnock commented 4 years ago

Awesome!

Not much can be tested here, just mounting, but it's still good to have that test to make sure all code links are safe: https://github.com/dunnock/react-sigma/blob/master/test/ForceLink.test.js

Also would be great if you can add your plugin to storybook, just like this: https://github.com/dunnock/react-sigma/blob/bbb85b1ec495447f8547d9e2d0be63aa2e667700/stories-src/storiesOfPlugins.js#L13-L20

Thank you!

jvkersch commented 4 years ago

@dunnock Many thanks for the quick review. I've added the tests and the storybook entry, please let me know if I've overlooked anything.

dunnock commented 4 years ago

Perfect, thanks @jvkersch . I will release minor update soon