dunovank / jupyter-themes

Custom Jupyter Notebook Themes
MIT License
9.74k stars 1.06k forks source link

solarizedl — matching parentheses are (almost) invisible #311

Open boffi opened 5 years ago

boffi commented 5 years ago

The theme solarizedl has a small misfeature, namely the foreground color used for matching parentheses, used when the cursor lies in the vicinity of one of them, is nearly indistinguishable from the default background. Please see the following scaled screenshot

image

taken from a 250% scaled browser window and further magnified by xmag — I say this because at normal scaling, with the help of anti-aliasing, the invisible-ness is much more severe...

I have had a look to solarizedl.css and it seems that the culprit is

div.CodeMirror span.CodeMirror-matchingbracket {
 color: #ffffff;
 font-weight: bold;
 background-color: #fdf6e3;
}

but I cannot tell where in solarized.less the clause above is generated, so I cannot propose a patch.


PS wrt matching parentheses, I checked all the other themes and they are OK, the matching parentheses are always correctly highlighted.

xzymustbexzy commented 4 years ago

@boffi
I meet the same problem and I solve it through modifying css file in ~/.jupyter/custom/custom.css directly.
Firstly, type

vim ~/.jupyter/custom/custom.css

then find

div.CodeMirror span.CodeMirror-matchingbracket   
{  
    color: #INSERT-YOUR-DESIRED-BRACKET-COLOUR-HERE ;  
    background-color: #INSERT-YOUR-DESIRED-BRACKET-BACKGROUND-COLOUR-HERE ;  
}

You may type /matchingbracket to find this block quickly.
Then you can change color. For example,

div.CodeMirror span.CodeMirror-matchingbracket {
 color: #ffffff;
 font-weight: bold;
 background-color: #d13f2a;
}

Restart the jupyter, you will see the difference.

image