solarizedd and onedork theme edit submissions

[pythonic2020]

Hello,

In several issue posts here and here I have already listed some minor, yet important, edits to the awesome solarizedd and onedork themes. I will summarize them here so perhaps dunovank can use them in a future jupyter-themes version.

solarizedd:

solarizedd.less file in styles folder: "solarized base colors" section @solar-base01: #bad0d9; # changes code color to a very light (almost white) cyan tint @solar-base1: #768282; # changes comment color to a dark shade of gray

"menus, dividers, prompt-borders, brackets" section @matching-bracket: lighten(@solar-base03, 10%); # lightens background of matching brackets

"solarized codemirror colors" section @cm-selected: darken(@solar-base02, 6%); # makes selected code easier to see:

cells.less file in layout folder: div.text_cell_render code {... (line 552) background-color: darken(@notebook-bg, 4%);

• darkens background of markdown text cells (e.g. text text text) so that these cells stand out more as in jupyter-lab dark theme

onedork:

"menus, dividers, prompt-borders, brackets" section @matching-bracket: darken(#4C8BE2, 10%); # darkens background of matching brackets

[MartSlaaf]

@pythonic2020 for the very first of your comments I suppose a bit different solution. There's just interchanged colors of original color scheme, and I suppose it's better keep em. What do you think?

See PR.

[pythonic2020]

Probably switching original colors is better, yes. Could you show which colors are switched in the solarizedd.less file?

[MartSlaaf]

Yeah, sure. My changes are here: https://github.com/dunovank/jupyter-themes/pull/392/files And here in original theme https://github.com/altercation/vim-colors-solarized/blob/528a59f26d12278698bb946f8fb82a63711eec21/colors/solarized.vim#L539 you see why I suppose them to be changed.

[pythonic2020]

Hmmm. Your suggestion would make code text #839496, correct? That is a light gray color, too close to comment color. I like a much lighter color for code text. Could you provide a screenshot showing how your suggestion looks in a notebook?

[MartSlaaf]

and it's quite close to how it looks in original color-scheme:

Though, original one having darker background, so, maybe we should check which colours are used for the background.

[pythonic2020]

I checked out the simple switching of original colors when I first started working on this, but I think my solution is much more pleasing and easy to read. That gray code color is too dark and too close to the comment color, and the comment color is also too dark. I also like the slightly lighter background as used by dunovank. Perhaps we should check out the custom solarized dark theme for Jupyter-lab that someone released as an extension.