search

dunovank / jupyter-themes

Custom Jupyter Notebook Themes
MIT License
9.74k stars 1.06k forks source link

Fix brackets highlighting in "solarizedl" #446

Open PeterMinin opened 3 years ago

PeterMinin commented 3 years ago

This fixes #311.

This makes the value theme-flavor-inverse in "solarizedl" actually an inverse of theme-flavor. All the dark themes have them differing, but in the light themes they are currently the same. The other light themes don't encounter the issue above, because they use a custom background color for highlighted brackets, but maybe they should be fixed accordingly too. In that case we might also want to adjust their background colors, so I leave that out of this fix.

I also checked that it's safe to change theme-flavor-inverse. It's only used in the CSS for span.CodeMirror-matchingbracket (the subject of the issue above) and span.CodeMirror-nonmatchingbracket (the red highlighting for an unmatched bracket); the latter becomes black on red, which I think is okay too.

PeterMinin commented 3 years ago

I now see there's already a PR open for this: #341. Oh well, maybe this will have better luck getting merged? :)