search

dunst-project / docker-images

Docker images for dunst (mainly for CI)
Other
2 stars 3 forks source link

Add Wayland build support #1

Closed fwsmit closed 3 years ago

fwsmit commented 3 years ago

I haven't tested it, but this should make sure the CI can build the dunst with wayland support.

tsipinakis commented 3 years ago

@bebehei Created/handled the CI items. I'm not sure if he's still active.

If not, I'll have to change the docker image as I don't have access to the DockerHub org. (And also figure out how to update the images)

bebehei commented 3 years ago

@tsipinakis Well yes, I'm rather inactive. But I'm still pingable.

IIRC the images should be built automatically, whenever pushed into git master branch here. Only if you add new images, you have to add the new Dockerfile.<name> -> tag <name> mapping.

bebehei commented 3 years ago

Changes look good.

@fwSmit Have you made make ci-build in this repository?

fwsmit commented 3 years ago

Changes look good.

@fwSmit Have you made make ci-build in this repository?

I have now, didn't want to download a million packages. Apparantly ubuntu doesn't have wayland package, so I fixed that. Arch linux doesn't build for me because of this bug https://bugs.archlinux.org/task/68057 (not because of my changes), so I didn't test further than arch (fedora isn't tested). Maybe we can just push this and see if the CI still works? We can always fix it later

bebehei commented 3 years ago

Hey @fwSmit yes, the arch docker image had some issues. I've fixed them now all. Also, I've added debian buster and ubuntu 20.04 images.

I'm currently building the new images with your packages and testing them locally.

bebehei commented 3 years ago

Thanks for the hint on Fedora, I'll try to update Fedora, too. Fedora 31 seems to be unsupported now.

bebehei commented 3 years ago

I've tested it and pushed your commit directly on HEAD via cherry-pick. In hindsight not the best decision. Your changes went into master, but this PR isn't displayed as merged. Sorry for that.

fwsmit commented 3 years ago

Thanks for the hint on Fedora, I'll try to update Fedora, too. Fedora 31 seems to be unsupported now.

I only meant that the building stopped when arch didn't work. But I'm glad if it helped you.

I've tested it and pushed your commit directly on HEAD via cherry-pick. In hindsight not the best decision. Your changes went into master, but this PR isn't displayed as merged. Sorry for that.

No problem. Thanks for your work!