search

dunst-project / docker-images

Docker images for dunst (mainly for CI)
Other
2 stars 3 forks source link

Make sure `doxygen` and `graphviz` are available. #5

Closed WhitePeter closed 2 years ago

WhitePeter commented 2 years ago

Necessary for testing the doc-doxygen target of dunst.

bebehei commented 2 years ago

@WhitePeter Do you need me here to merge/review it?

bebehei commented 2 years ago

Ok, I've seen the old commit b61cc263958837ffd19ba4fcb99ab3e1806ca577. This is a good intention to use doxygen in the CI, too.

But there is also Dockerfile.misc-doxygen, which only runs doxygen. Using this in the CI instead of installing it in every image will be slimmer. Would you mind integrating this into the CI?

WhitePeter commented 2 years ago

Ok, I've seen the old commit b61cc263958837ffd19ba4fcb99ab3e1806ca577. This is a good intention to use doxygen in the CI, too.

But there is also Dockerfile.misc-doxygen, which only runs doxygen. Using this in the CI instead of installing it in every image will be slimmer. Would you mind integrating this into the CI?

I can try, but I know too little about how to do it, I'm afraid. Would that mean to make another PR for this repo or can that be done by a simple change to .github/workflows/main.yml in the dunst repo?

WhitePeter commented 2 years ago

OK, I think I have got something working, took a little trial and error, though. Please have a look at this PR, if you don't mind.

fwsmit commented 2 years ago

I'll close this PR since I don't think we'll need it