Closed notevenaperson closed 1 year ago
With 26 notifications in dunst history.
time
./(old)notification-history.sh 6.56s user 0.43s system 99% cpu 7.057 total
./(new)notification-history.sh 0.37s user 0.11s system 45% cpu 1.066 total
Quite the enhancement. Although I cannot say something about the logic itself I noticed one thing. There is now some mixup with tabs and spaces, which can indent the code in a funny way
I screwed trying to amend a commit so I'm just going to remake the pull request
My main intention is minimize calls to jq since (on my thinkpad) each takes 50-100 ms, which can add up to a noticeable delay (~400ms for each notification) until the window first appears.
This new version also fixes a bug where notification that contained newlines, those \ns were wrongly interpreted by the script Try: $ notify-send "The\ntrick"
When selecting or reading a notification, the display format has changed from 1 to 2: The important information is prioritized left-to-right. 1) 0003 - NetworkManager: "Wi-Fi Networks Available" (at 10:01:22 AM) 2) "Wi-Fi Networks Available" (NetworkManager) - 10:01:22 AM - 0003