dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.6k stars 342 forks source link

notification-history.sh: Rewrite for speed #1123

Closed notevenaperson closed 1 year ago

notevenaperson commented 1 year ago
notevenaperson commented 1 year ago

With 26 notifications in dunst history.

time
./(old)notification-history.sh  6.56s user 0.43s system 99% cpu 7.057 total
./(new)notification-history.sh  0.37s user 0.11s system 45% cpu 1.066 total
Narrat commented 1 year ago

Quite the enhancement. Although I cannot say something about the logic itself I noticed one thing. There is now some mixup with tabs and spaces, which can indent the code in a funny way

notevenaperson commented 1 year ago

I screwed trying to amend a commit so I'm just going to remake the pull request