dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.52k stars 338 forks source link

Fix #1147 by checking NULL pointers #1148

Closed ShellCode33 closed 1 year ago

ShellCode33 commented 1 year ago

Please review carefully, I'm not familiar at all with dunst nor Wayland. This might not be the right way to fix #1147.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1148 (42c8b84) into master (7bd8e6b) will decrease coverage by 0.07%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   65.96%   65.90%   -0.07%     
==========================================
  Files          46       46              
  Lines        7548     7555       +7     
==========================================
  Hits         4979     4979              
- Misses       2569     2576       +7     
Flag Coverage Δ
unittests 65.90% <0.00%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/draw.c 51.35% <0.00%> (-0.33%) :arrow_down:
src/wayland/wl.c 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fwsmit commented 1 year ago

The change seems sensible. Have you tested if this fixes the bug?

ShellCode33 commented 1 year ago

The bug doesn't seem to occur anymore with that patch

EDIT: dunst has been running for more than 6 hours with no issue

fwsmit commented 1 year ago

Thanks! The patch looks good, so I'll merge it