dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.52k stars 338 forks source link

fixed progress_bar_corner_radius issues #1183

Closed vatsal999 closed 7 months ago

vatsal999 commented 1 year ago

fixes #1178

codecov-commenter commented 1 year ago

Codecov Report

Merging #1183 (e8e9960) into master (dfab9f0) will decrease coverage by 0.04%. The diff coverage is 20.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   66.03%   65.99%   -0.04%     
==========================================
  Files          46       46              
  Lines        7595     7597       +2     
==========================================
- Hits         5015     5014       -1     
- Misses       2580     2583       +3     
Flag Coverage Δ
unittests 65.99% <20.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/draw.c 51.04% <0.00%> (-0.31%) :arrow_down:
src/settings.c 47.22% <33.33%> (-0.40%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fwsmit commented 1 year ago

Hi, could you take a look at the comments I made above?

fwsmit commented 7 months ago

With #1227 merged, this should not be needed anymore.

fwsmit commented 7 months ago

Thank you for your work, though