search

dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.42k stars 338 forks source link

Suppress alpine allocation issue #1284

Closed zappolowski closed 4 months ago

zappolowski commented 4 months ago

This is related to the introduction of wordexp in e9a27c0 but did go unnoticed as it seems to be detected just by newer versions of valgrind (I would rule out musl here as the wordexp code was not touched in ages and getdelim was last mentioned in the 1.1.22 version while the old alpine image already shipped 1.1.24).

This isn't an issue with the current images but newer versions of alpine fail to complete without it (see this comment).

codecov-commenter commented 4 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed5bcb4) 64.53% compared to head (415d8b3) 64.48%. Report is 5 commits behind head on master.

Files Patch % Lines
src/wayland/wl.c 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1284 +/- ## ========================================== - Coverage 64.53% 64.48% -0.05% ========================================== Files 48 48 Lines 7914 7918 +4 ========================================== - Hits 5107 5106 -1 - Misses 2807 2812 +5 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `64.48% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zappolowski commented 4 months ago

@fwsmit This also includes the changes from #1282 to have a working pipeline. The branches should be merged in creation order (the superflous commit) should vanish then.

fwsmit commented 4 months ago

Hopefully the ci works now