search

dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.56k stars 340 forks source link

Portability fixes #1288

Closed 0-wiz-0 closed 7 months ago

0-wiz-0 commented 7 months ago

These patches are from pkgsrc and increase portability of dunst to other operating systems.

bynect commented 7 months ago

Related to #1171.

For the features.h it seems like it is used just to check __GLIBC__ once, so maybe we can change it so we never need it?

Similarly for the button codes, I think we can remove the reliance on linux codes and just define an enum. (since they are arbitrary number anyway and are not used nowhere else) What do you think?@fwsmit

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.46%. Comparing base (ab38321) to head (8baccb8).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1288 +/- ## ======================================= Coverage 64.46% 64.46% ======================================= Files 48 48 Lines 7920 7920 ======================================= Hits 5106 5106 Misses 2814 2814 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `64.46% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fwsmit commented 7 months ago

What operating systems are you trying to port to? That would be good to know. The button codes are plain numbers, but we get them from wayland / X11 I believe. So we need to use those specific numbers. I didn't check it though

0-wiz-0 commented 7 months ago

pkgsrc is cross-platform. The evdev patches are needed at least on NetBSD, and the find patch is (I think) needed on Solaris/Illumos.

bynect commented 7 months ago

I resolved a conflict with #1290. Also thanks for the pr, I'll merge it 👍🏻