Fix logging in icon code

bynect commented 4 months ago

Remove extra newlines and move a string empty upwards

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.79%. Comparing base (b6a8a19) to head (9a9c74a). Report is 13 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1296 +/- ## ========================================== + Coverage 64.46% 64.79% +0.32% ========================================== Files 48 48 Lines 7920 7962 +42 ========================================== + Hits 5106 5159 +53 + Misses 2814 2803 -11 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1296/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1296/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `64.79% <100.00%> (+0.32%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Rentib commented 4 months ago

Was it expected that setting default_icon = "" uses an icon?

[urgency_normal]
  timeout = 10
  default_icon = ""

This for example still uses an icon for notifications with normal urgency. The icon used is the default one.

bynect commented 4 months ago

Was it expected that setting default_icon = "" uses an icon?
[urgency_normal]
  timeout = 10
  default_icon = ""
This for example still uses an icon for notifications with normal urgency. The icon used is the default one.

What do you mean it uses the default icon? Also could you please open an issue

Also, is this something that happened after this commit?

Rentib commented 4 months ago

Was it expected that setting default_icon = "" uses an icon?
[urgency_normal]
  timeout = 10
  default_icon = ""
This for example still uses an icon for notifications with normal urgency. The icon used is the default one.
What do you mean it uses the default icon? Also could you please open an issue

Also, is this something that happened after this commit?

If you specify icon_theme in configuration file, then for all notifications dunst will use an icon from the theme, unless you configure it otherwise. If you check for example Papirus icons then dunst will use emblem-information icon I think.

Example config:

[global]
  enable_recursive_icon_lookup = true
  icon_theme = "Adwaita, Papirus"

bynect commented 4 months ago

Was it expected that setting default_icon = "" uses an icon?
[urgency_normal]
  timeout = 10
  default_icon = ""
This for example still uses an icon for notifications with normal urgency. The icon used is the default one.
What do you mean it uses the default icon? Also could you please open an issue

Also, is this something that happened after this commit?
If you specify icon_theme in configuration file, then for all notifications dunst will use an icon from the theme, unless you configure it otherwise. If you check for example Papirus icons then dunst will use emblem-information icon I think.

Example config:
[global]
  enable_recursive_icon_lookup = true
  icon_theme = "Adwaita, Papirus"

I don't get this behavior. Please open an issue including your dunst version and dunstrc so that I can investigate

dunst-project / dunst

Fix logging in icon code #1296

Codecov Report