search

dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.56k stars 340 forks source link

Fix settings initialization #1299

Closed bynect closed 6 months ago

bynect commented 7 months ago

settings.print_notifications and settings.startup_notification were always set to zero by load_settings

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.06%. Comparing base (15b1e8c) to head (53ada2a).

Files Patch % Lines
src/dunst.c 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1299 +/- ## ======================================= Coverage 65.06% 65.06% ======================================= Files 48 48 Lines 8173 8173 ======================================= Hits 5318 5318 Misses 2855 2855 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1299/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `65.06% <33.33%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zappolowski commented 6 months ago

Please rebase to current master to pick up the new actions.

bynect commented 6 months ago

I'll merge this