Do not resolve paths in get_pixbuf_from_file

[zappolowski]

The arguments should be already resolved:

• if it's either new_icon or default_icon it should be done while parsing the configuration
• if it's coming from DBus whoever sent the message should give a fully resolved path

This fixes #1307.

[bynect]

Am I right in thinking that string_to_path is called in the option parser for the icon paths?

[zappolowski]

Am I right in thinking that string_to_path is called in the option parser for the icon paths?

Yes, both default_icon and new_icon are TYPE_PATH and string_to_path is called on them in set_from_string.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.71%. Comparing base (07b68f0) to head (26ea2de). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1314 +/- ## ========================================== - Coverage 65.71% 65.71% -0.01% ========================================== Files 50 50 Lines 8041 8038 -3 Branches 925 925 ========================================== - Hits 5284 5282 -2 + Misses 2757 2756 -1 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1314/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1314/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `65.71% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bynect]

👍🏻