dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.56k stars 340 forks source link

Test png icon if svg fails to load #1329

Closed bynect closed 5 months ago

bynect commented 5 months ago

Made valid.png 16x16 to be consistent with valid.svg and reworked notification_load_icon_with_scaling to use png if svg fails to load (this is due the missing librsvg which is a runtime dependency)

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 65.68%. Comparing base (07b68f0) to head (f107bba). Report is 3 commits behind head on master.

Files Patch % Lines
test/notification.c 61.53% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1329 +/- ## ========================================== - Coverage 65.71% 65.68% -0.03% ========================================== Files 50 50 Lines 8041 8047 +6 Branches 925 928 +3 ========================================== + Hits 5284 5286 +2 - Misses 2757 2761 +4 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1329/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1329/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `65.68% <61.53%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.