search

dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.42k stars 338 forks source link

Fix coverage for forks #1331

Closed bynect closed 2 months ago

bynect commented 2 months ago

fix #1327

bynect commented 2 months ago

My bad, I just realized that it's all the workflows and not just coverage that runs on my fork. Does this happen also to you @zappolowski ?

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.68%. Comparing base (07b68f0) to head (d53b15f). Report is 5 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1331 +/- ## ========================================== - Coverage 65.71% 65.68% -0.03% ========================================== Files 50 50 Lines 8041 8047 +6 Branches 925 928 +3 ========================================== + Hits 5284 5286 +2 - Misses 2757 2761 +4 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1331/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `65.68% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bynect commented 2 months ago

image

zappolowski commented 2 months ago

The error you're encountering is due to missing git tags. As git describe --tags is used to create VERSION, this falls back to VERSION := "1.10.0-non-git" which then makes the tests fail.

Short: Also fork the tags from the main repository and you're good.

bynect commented 2 months ago

The error you're encountering is due to missing git tags. As git describe --tags is used to create VERSION, this falls back to VERSION := "1.10.0-non-git" which then makes the tests fail.

Short: Also fork the tags from the main repository and you're good.

But before this didn't cause any issue