dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.42k stars 338 forks source link

Re-enable coverage for all pushes #1335

Closed zappolowski closed 2 months ago

zappolowski commented 2 months ago

There should be a valid token now and thus the restriction for pull requests should not be needed anymore.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.92%. Comparing base (bd5b333) to head (0eaeef3). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1335 +/- ## ========================================== + Coverage 65.65% 65.92% +0.26% ========================================== Files 50 50 Lines 8051 8070 +19 Branches 928 925 -3 ========================================== + Hits 5286 5320 +34 + Misses 2765 2750 -15 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1335/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `65.92% <ø> (+0.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bynect commented 2 months ago

Shouldn't it be repo == dunst-project/dunst like before? Or was it from another part of the workflow?

zappolowski commented 2 months ago

This shouldn't be needed anymore, as v4 of the action should already disable uploading of the report on forks (which wasn't the case before).

bynect commented 2 months ago

This shouldn't be needed anymore, as v4 of the action should already disable uploading of the report on forks (which wasn't the case before).

Ok then go ahead.