search

dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.56k stars 340 forks source link

Add an optional id to `dunstctl close` #1351

Closed bynect closed 5 months ago

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.95%. Comparing base (9fb0216) to head (14ecba5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1351 +/- ## ======================================= Coverage 65.95% 65.95% ======================================= Files 50 50 Lines 8209 8209 Branches 962 962 ======================================= Hits 5414 5414 Misses 2795 2795 ``` | [Flag](https://app.codecov.io/gh/dunst-project/dunst/pull/1351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dunst-project/dunst/pull/1351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project) | `65.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dunst-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bynect commented 5 months ago

Looks good. It would be nice to adjust the completions as well (at least the summary strings) for zsh and fish as they're misleading otherwise.

right, forgot about that 👍🏻

bynect commented 5 months ago

@zappolowski I fixed some typos and updated the completions. Unfortunately we can't autocomplete the id (see my suggestion in #1348).

bynect commented 5 months ago

done.

unrelated question, should we add a completion for dunstify later?

zappolowski commented 5 months ago

unrelated question, should we add a completion for dunstify later?

Yes, this would make sense. I just added it for fish as that's what I'm using.