search

dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.56k stars 340 forks source link

Resolve `~` or `$HOME` in `icon_path` #1371

Open danielwerg opened 1 month ago

danielwerg commented 1 month ago

Issue description

dunst doesn't resolve ~ or $HOME in icon_path. It was claimed to be fixed in 1.4 by @tsipinakis and here by @bebehei so I'm little puzzled.

Installation info

Minimal dunstrc ```ini enable_recursive_icon_lookup = false # doesn't work icon_path = ~/.config/dunst/icons/ # also doesn't work #icon_path = $HOME/.config/dunst/icons/ # works #icon_path = /home//.config/dunst/icons/ ```

Related: #350 #520

bebehei commented 1 month ago

Is this a regression?

danielwerg commented 1 month ago

Is this a regression?

I haven't edited dunst config before so not sure.

bynect commented 1 month ago

I'm not sure if this is a regression. the problem seems to lie here https://github.com/dunst-project/dunst/blob/844167abe1f7845bfe7c81797da36be28362e7b9/src/icon.c#L241

I will try to add the recognition of ~

zappolowski commented 1 week ago

@danielwerg could you try #1383?