dunst-project / dunst

Lightweight and customizable notification daemon
https://dunst-project.org
Other
4.61k stars 342 forks source link

SIGCONT / SIGTSTP handling #665

Closed mjsir911 closed 5 years ago

mjsir911 commented 5 years ago

Hello,

Currently to pause and resume dunst is SIGUSR1 (pause) and SIGUSR2 (resume)

I greatly appreciate this feature, but I believe the signals SIGTSTP (keyboard stop) and SIGCONT would be better suited for this task.

I don't really have a user story for this, but I could imagine tools would be able to take advantage of this more semantically correct signal handling.

Current behaviour of dunst is to ignore SIGTSTP signals

bebehei commented 5 years ago

SIGUSR* and SIGTSTP/SIGCONT signals differ in a simple and easy way.

So in the semantics differ. We usually don't get spawned in a terminal and dunst has to run all the time. If we really stop the dunst process, many clients may fuck up and run into timeouts until finally DBus will probably start a new dunst instance.

I don't see where the semantics TSTP and CONT are "better suited" for dunst. Also, I'd like to remind you of #445. We plan to implement the functionality by a proper command line control.

mjsir911 commented 5 years ago

Alright, thanks for your consideration.

Have a nice day