search

duo-labs / EFIgy

A small client application that uses the Duo Labs EFIgy API to inform you about the state of your Mac EFI firmware
http://efigy.io
BSD 3-Clause "New" or "Revised" License
510 stars 39 forks source link

Incorrect results? #17

Closed Lloir closed 6 years ago

Lloir commented 6 years ago 
# Results:

EFI firmware version check:
    [-] ATTENTION - You are running an unexpected firmware version given the model of your system (MacBookPro9,2) and OS build you have installed (16G1114). Your firmware is MBP91.00D7.B00, the firmware we expected to see is MBPro91.00D7.B00.

Highest build number check:
    [-] ATTENTION - You are NOT running the latest release build number of your OS version (10.12.6). Your build number is 16G1114, the latest release build number is 16G1036
iMatthewCM commented 6 years ago

Seeing this too. It looks like the difference is EFIgy is expecting "MBPro91.00D7.B00" and the system is returning "MBP" and then the exact same numbers. So, the firmware looks like it IS correct, but EFIgy is expecting the wrong thing.

Edit: My above comment was just looking at the EFI check, but with the Highest Build Number Check the build number is indeed off - I'm wondering if maybe they're not accounting for the recent security patches?

G60GT commented 6 years ago

Same issue with the build number on fully patched 10.13.2 system with supplemental update applied:

Highest build number check: [-] ATTENTION - You are NOT running the latest release build number of your OS version (10.13.2). Your build number is 17C205, the latest release build number is 17C88

bruienne commented 6 years ago

Hey there! We found the issue that could cause out of date results in certain corner cases and patched the API to fix it. If you could, please test whether the returned results for your endpoints are now as expected.

The dataset is up to date with macOS 10.13.3 Supplemental Update (build 17D102 for non-iMac Pro and 17D2102/17D2104 for iMac Pro endpoints). Thanks for your reports!

bruienne commented 6 years ago

@Lloir @G60GT @iMatthewCM When you get a chance let us know whether the issue still exists after aforementioned API update so we can go ahead and close this.

G60GT commented 6 years ago

I do get the expected results now on my fully patched system. Thank you!

MyNameIsMeerkat commented 6 years ago

Excellent to hear, we'll close out this issue. Thanks for letting us know about the problem