adds --partition option, fixes #623

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.

BSD 3-Clause "New" or "Revised" License

6k stars 810 forks source link

adds --partition option, fixes #623 #624

Closed Cerebus closed 4 years ago

Cerebus commented 4 years ago

Adds --partition flag with default value aws
Adds this value to service.get_available_regions() call

claassistantio commented 4 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Cerebus commented 4 years ago

FYI, signed the CLA, but it's not updating.

0xdabbad00 commented 4 years ago

I've asked some folks to check up on why the CLA isn't updating. Thank you for the PR!

0xdabbad00 commented 4 years ago

@Cerebus See my comment about not being able to merge due to some of the functionality having been commented out. Maybe a command-line flag could avoid this code, or maybe you could check if the iam data exists and skip if it doesn't?

0xdabbad00 commented 4 years ago

Closing this due to staleness as it breaks too many things.