Check for node._parent before iterating

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.

BSD 3-Clause "New" or "Revised" License

6k stars 810 forks source link

Check for node._parent before iterating #626

Closed Cerebus closed 4 years ago

Cerebus commented 4 years ago

VpcEndpoint has _parent set to None when the endpoint is not in the vpc filter list. Skip these objects.

Fixes #625

claassistantio commented 4 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Cerebus commented 4 years ago

Still stuck w/ CLA pending.

Cerebus commented 4 years ago

Bump. I'm already G=getting tired of maintaining a fork. :)

Cerebus commented 4 years ago

Whoops, wrong button.

0xdabbad00 commented 4 years ago

Thanks, I'll look into merging this tonight. Sorry for the issues with the CLA. The folks that can fix it seem to have been having trouble.

0xdabbad00 commented 4 years ago

Thank you! Sorry for the delays and CLA problems. I'll take your comment at https://github.com/duo-labs/cloudmapper/pull/624#issuecomment-563247013 as evidence that signed the CLA.