search

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
6k stars 810 forks source link

MAX RETRIES configurable #657

Open andrewkrug opened 4 years ago

andrewkrug commented 4 years ago

Break out the MAX RETRIES to a parameter in the cdk_app.yml to allow the user to choose how long to wait. In larger AWS accounts this could be important.

https://github.com/duo-labs/cloudmapper/blob/1e60e1fb0bf5ad71d8514c2f5a3a2696b130f4cc/commands/collect.py#L19

0xdabbad00 commented 4 years ago

This PR added a command-line parameter to bump the retry count: https://github.com/duo-labs/cloudmapper/pull/614/files#diff-f6fe91e3358619090b886027361d2b1eR498

I'm not sure when one of those retries happens versus the other, so I don't know what which would be best to make configurable from the CDK, but I think the command-line parameter from that PR would be easiest.

andrewkrug commented 4 years ago

I'd probably just break this out to a setting in the cdk yaml configuration. For my accounts 10 seemed to be the sweet spot.