duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
5.96k stars 800 forks source link

Added GSute SAML provider node support for WebOfTrust report #756

Closed rvsoni closed 4 years ago

rvsoni commented 4 years ago

CloudMapper throws error on creating WebOfTrust report while using GSuite as AWS IAM Federation.

Traceback (most recent call last): File "cloudmapper.py", line 72, in main() File "cloudmapper.py", line 66, in main commands[command].run(arguments) File "/home/ravi.soni/git/cloudmapper/commands/weboftrust.py", line 528, in run cytoscape_json = weboftrust(args, accounts, config) File "/home/ravi.soni/git/cloudmapper/commands/weboftrust.py", line 411, in weboftrust get_nodes_and_connections(account, nodes, connections, args) File "/home/ravi.soni/git/cloudmapper/commands/weboftrust.py", line 392, in get_nodes_and_connections get_iam_trusts(account, nodes, connections, connections_to_get) File "/home/ravi.soni/git/cloudmapper/commands/weboftrust.py", line 259, in get_iam_trusts raise Exception( Exception: Unknown federation provider: arn:aws:iam::xxxxxxxxxxxx:saml-provider/gsuite-xxxxxxx

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ravi Soni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

0xdabbad00 commented 4 years ago

Thank you @rvsoni. This LGTM, but can you sign the CLA so we can merge it in?

rvsoni commented 4 years ago

Hi, @0xdabbad00

I am not sure, something is wrong in signing CLA, I tried a couple of times since yesterday after creating PR, even just now I tried and it does not show the CLA is signed.

See attached image, can you pl. check it,

Screenshot from 2020-08-22 08-31-03

Thanks, Ravi

rvsoni commented 4 years ago

CLA assistant shows that I have signed agreement too, but PR request shows it's pending.

Selection_070

Ravi

0xdabbad00 commented 4 years ago

Thanks @rvsoni, we've had some issues in the past with the CLA service. Sometimes it's due to the email in the commit history being different than the one you are signed into Github with. I don't know what is causing the problem in this case, but your comments here are sufficient evidence that you've signed it, so this can be merged @kylelady and @jordan-wright