search

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
5.94k stars 800 forks source link

`aws eks describe-cluster` takes --name #768

Closed dhutty closed 3 years ago

dhutty commented 3 years ago

My collect step failed with:

...
Summary: 275 APIs called. 1 errors
Failures:
  eks.describe_cluster({'cluster': 'example-foo'}): Parameter validation failed:
Missing required parameter in input: "name"

which led me to: https://github.com/duo-labs/cloudmapper/issues/729 But the AWS CLI/SDK shows that describe-cluster takes --name not --cluster, so this PR changes the parameter we are passing. And allows collect to complete successfully.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

0xdabbad00 commented 3 years ago

Looks like you're right. The collection for eks describe-cluster was added in #742, but from what I see in the AWS CLI, I think you're correct that this should be name.

LGTM, @jordan-wright @kylelady this can be merged.