Fixed collect when some services return AccessDenied

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.

BSD 3-Clause "New" or "Revised" License

5.94k stars 800 forks source link

Fixed collect when some services return AccessDenied #776

Closed jtyers closed 3 years ago

jtyers commented 3 years ago

On our environment we have SCPs in place that deny access to some services and regions. Since these fail to return data cloudmapper encounters an error when reading this data back. This PR fixes that, by only reading the data if the files exist.

CLAassistant commented 3 years ago

All committers have signed the CLA.

0xdabbad00 commented 3 years ago

Thank you @jtyers and sorry for the delay in getting to this. LGTM. This can be merged @steiza

jtyers commented 3 years ago

Cheers!

On Thu, 3 Dec 2020 at 15:14, Zach Steindler notifications@github.com wrote:

Merged #776 https://github.com/duo-labs/cloudmapper/pull/776 into main.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/duo-labs/cloudmapper/pull/776#event-4068036333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRVU34MKKVONDX6MK54N4LSS6TODANCNFSM4SERN7VQ .