search

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
5.94k stars 800 forks source link

Add cloudaware and cloudguard account IDs #806

Closed ctennis closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

0xdabbad00 commented 3 years ago

Thank you @ctennis. Are you able to sign the CLA so I can get this merged in?

ctennis commented 3 years ago

Yep, just signed.

0xdabbad00 commented 3 years ago

I've add an issue (#816) to give myself a way of indicating when a vendor is not publicly documented. Once that is done, I'll get this merged.

kbroughton commented 3 years ago

That's fair. It may be that i linked the instructions and got it from elsewhere. It does come up in a google search. I'm fine with removing it though. https://www.google.com/search?q=884047677700&oq=884047677700&aqs=chrome..69i57.323j0j7&sourceid=chrome&ie=UTF-8

0xdabbad00 commented 3 years ago

@kbroughton Your google search link is for the account ID for Emnify which is right above Cloudaware which my comment was for, and this PR was from ctennis. Your PR is in #735 and I'm going to look at that next. :)

0xdabbad00 commented 3 years ago

@ctennis I've made a change to this PR, which involves me resubmitting these commits in a separate PR. You'll still show up in the commit history, but there isn't a good way of doing this otherwise. I just needed to remove the source from cloudaware to indicate this vendor is uncomfirmed.