Desync mitigation check on ELBv1

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.

BSD 3-Clause "New" or "Revised" License

5.94k stars 800 forks source link

Desync mitigation check on ELBv1 #807

Closed cbeltranbird closed 3 years ago

cbeltranbird commented 3 years ago

Based on recommended guidance from AWS, sets a new ELBV1_DESYNC_MITIGATION check.

This change includes:

A new audit_config
describe-load-balancer-attributes collection task,
The check logic in audit.py,

The check is very similar to the ELBv2 check, but targets a different resource in a different way. I don't believe they should be merged, but happy to do so, if needed.

CLAassistant commented 3 years ago

All committers have signed the CLA.

0xdabbad00 commented 3 years ago

LGTM. Great catch @cbeltranbird. I hadn't realized the older ELBs were also impacted. This can be merged @steiza