search

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
5.9k stars 800 forks source link

fix_federation_providers #839

Closed kbroughton closed 3 years ago

kbroughton commented 3 years ago

Allow custom federation providers by adding items to config/custom_federation_providers.yaml

Fixes https://github.com/duo-labs/cloudmapper/issues/189

0xdabbad00 commented 3 years ago

I'm not sure what happened with this PR as it includes a ton of additions to vendor_accounts.yaml, but as far as I can tell, those "additions" already exist in the file.

My thoughts for this problem (#189) was that I would use the actual SAML information from iam:ListSamlProviders and iam:GetSamlProviders which is now collected here: https://github.com/duo-labs/cloudmapper/blob/main/collect_commands.yaml#L49

That information should avoid people having to recreate that data manually into the new config/custom_federation_providers.yaml that your PR creates.