Fix issues #823 , #620 and #834

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.

BSD 3-Clause "New" or "Revised" License

5.9k stars 800 forks source link

Fix issues #823 , #620 and #834 #851

Closed roskyfrosky closed 3 years ago

roskyfrosky commented 3 years ago

Fix Issue 834

CLAassistant commented 3 years ago

All committers have signed the CLA.

w0rmr1d3r commented 3 years ago

@roskyfrosky this actually resolves issue #620 as well, but I made a separate PR for it https://github.com/duo-labs/cloudmapper/pull/849

roskyfrosky commented 3 years ago

ok @w0rmr1d3r! I have added Turbot vendor too named in #823

w0rmr1d3r commented 3 years ago

Awesome @roskyfrosky ! Then, this PR actually solves issues #823 , #620 and #834 ! Can you put that in the description? Thank you!

roskyfrosky commented 3 years ago

@w0rmr1d3r Done.

roskyfrosky commented 3 years ago

@w0rmr1d3r Added some checks for collect and stats command. Added the posibility to choose the output filename for report command too.

w0rmr1d3r commented 3 years ago

Alright @roskyfrosky ! I've been monitoring the PR lately. It actually does more than one thing and more than what the title and description say. I can see that it's getting updated from your main branch. It'd be better if it got split into different PRs, and every PR only fixed/solved one thing instead. That's only my opinion, I don't know how the owners of the repo want it. But for me, it'd be easier to review and to merge.

roskyfrosky commented 3 years ago

@w0rmr1d3r ok! I close this PR and open a new one for each of the changes.