Conflicting python package versions since dependabot commit

bentefay commented 3 years ago

Running docker build -t cloudmapper . as per the README currently yields the following error:

ERROR: Cannot install -r requirements.txt (line 5) and urllib3==1.26.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested urllib3==1.26.5
    botocore 1.17.6 depends on urllib3<1.26 and >=1.20; python_version != "3.4"

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

This commit from dependabot appears to have created the problem: https://github.com/duo-labs/cloudmapper/commit/97e0ebcbd7498c3b2beaeeccebc9bbf8171232a1

Editing requirements.txt and setting the urlib version back fixes the problem: urllib3==1.25.9

mladjen commented 3 years ago

Same

ebellavance commented 3 years ago

Same here

ERROR: requests 2.22.0 has requirement urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1, but you'll have urllib3 1.26.5 which is incompatible. ERROR: botocore 1.17.6 has requirement urllib3<1.26,>=1.20; python_version != "3.4", but you'll have urllib3 1.26.5 which is incompatible.

w0rmr1d3r commented 3 years ago

What if we upgrade requests and botocore dependencies so they can admit the new version of urllib3 ?

justhereforthecroissants commented 3 years ago

Same issue here.

@w0rmr1d3r urllib3==1.25.11 works

w0rmr1d3r commented 3 years ago

don't you worry @cajual , already exists a PR to fix this, however, it needs to be reviewed and merged -> https://github.com/duo-labs/cloudmapper/pull/876 That way, we don't need to downgrade a dependency

petatemarvin26 commented 2 years ago

try to not explicit the version of urllib3, from your requirements.txt ... Flask=3.0.1 urllib3 ...

duo-labs / cloudmapper

Conflicting python package versions since dependabot commit #875