search

duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
5.9k stars 797 forks source link

Fixes new requirements in requirements.txt, as well as 3 missing null checks, and the styles for the iam graphing #885

Closed commjoen closed 2 years ago

commjoen commented 2 years ago

This is an extended fix of what we see in #879 : it fixes the 3 missing empty/null checks as well as the requirements.txt, as well as the styles reference for the iam Graphing

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

commjoen commented 2 years ago

@w0rmr1d3r that is true, but given that this mr has not been merged for the last 3 weeks, I figured: for those that want a "1-stop-shop-departure": here you go :).

w0rmr1d3r commented 2 years ago

Great @commjoen ! Take a look, that there are a lot of PRs fixing some open issues, but haven't been reviewed :/ and not only for the last 3 weeks, I'm talking about months here.

commjoen commented 2 years ago

@w0rmr1d3r the only problem i might have to fix for now (which does not owrk for me) is visualizing the iAM graph.. was there an MR that already fixed this :) ?

w0rmr1d3r commented 2 years ago

Can't find any PR regarding that, neither any issue. Have you opened one @commjoen ?

commjoen commented 2 years ago

Not yet, as i was trying to figure out what was going wrong... but still did not find an answer (as occupied by mulitple things here in a security team :P )

commjoen commented 2 years ago

See #1063114 : this fixes the styles so you can generate graphs for iam again.

w0rmr1d3r commented 2 years ago

Perfect @commjoen !

commjoen commented 2 years ago

@w0rmr1d3r do you know whether there is a way to visualize trust relationships between roles? because i am missing half of them.. but no errors anywhere...

w0rmr1d3r commented 2 years ago

Don't know at the moment 😕

commjoen commented 2 years ago

Any updates on this MR?