duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.
BSD 3-Clause "New" or "Revised" License
5.9k stars 797 forks source link

Could you Dockerise this project such that it can run regardless of environment? Thanks #890

Open jiacheng-0 opened 2 years ago

jiacheng-0 commented 2 years ago

Please mention the following:

sudo apt-get install autoconf automake libtool python3.7-dev python3-tk jq awscli on Ubuntu 20.04 LTS (WSL)

No virtual env, just installation

w0rmr1d3r commented 2 years ago

Hello @jiacheng-0 ,

It actually exists this -> https://github.com/duo-labs/cloudmapper#using-a-docker-container

Have you checked it out?

Cheers!

chrisjohnson00 commented 2 years ago

Hello @jiacheng-0 ,

It actually exists this -> https://github.com/duo-labs/cloudmapper#using-a-docker-container

Have you checked it out?

Cheers!

The container doesn't build... so far here's the errors I've seen:

Then there's this:

ERROR: Cannot install -r requirements.txt (line 5) and urllib3==1.26.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested urllib3==1.26.5
    botocore 1.17.6 depends on urllib3<1.26 and >=1.20; python_version != "3.4"

So it looks like someone hasn't tested this enough.

After deleting python3.7-dev from the apt install in Dockerfile and removing urllib3==1.26.5 from requirements.txt I'm able to build the container... will edit if I get around to getting it to run (just playing with this tool on a whim)

AFAIK it works with the above changes, I'll PR the changes and you can decide for yourselves.

w0rmr1d3r commented 2 years ago

If it's something regarding conflicts or dependencies in the requirements.txt file, there are a lot of open issues about that. Check them as well, since this error:

The conflict is caused by:
    The user requested urllib3==1.26.5
    botocore 1.17.6 depends on urllib3<1.26 and >=1.20; python_version != "3.4"

Has already been fixed in other PRs, yet not merged.

chrisjohnson00 commented 2 years ago

Has already been fixed in other PRs, yet not merged.

Yes, that's 1 of 2 things I had to fix to get the container to build.