duo-labs / cloudmapper

CloudMapper helps you analyze your Amazon Web Services (AWS) environments.

BSD 3-Clause "New" or "Revised" License

5.9k stars 797 forks source link

bug: #904 cdk version upgrade for node10x deprecation #905

Closed ejohn20 closed 2 years ago

ejohn20 commented 2 years ago

904: Upgraded CDK version to 1.132.0 to avoid install error with node10x deprecation.

CLAassistant commented 2 years ago

)
All committers have signed the CLA.

0xdabbad00 commented 2 years ago

Eek, I'm generally scared of PRs with 5000+ changes due to the risk of some sort of backdoored library slipping into one of those packages, but Eric is a known person in cloud security, and although I tried to skim this for review, I'm mostly just trusting this.

ejohn20 commented 2 years ago

@0xdabbad00 Agreed, the package lock json diff did not diff hardly at all. Just a heads up, I had a student tell me today their install failed still 😢

So I'm looking into this again and might have a follow up PR if anything else needs to be updated...