duo-labs / cloudtracker

CloudTracker helps you find over-privileged IAM users and roles by comparing CloudTrail logs with current IAM policies.
BSD 3-Clause "New" or "Revised" License
887 stars 111 forks source link

Minor README fix #40

Closed poflynn closed 6 years ago

poflynn commented 6 years ago

Fixed 'demo_iam.json' filename in step 3 to match the filename in step 2. I was getting the error below when I followed the instructions and it took me a while to notice the filename difference.


Traceback (most recent call last):
  File "/Users/paul.oflynn/workspace/venv/bin/cloudtracker", line 11, in <module>
    load_entry_point('cloudtracker==2.1.2', 'console_scripts', 'cloudtracker')()
  File "/Users/paul.oflynn/workspace/venv/lib/python3.7/site-packages/cloudtracker/cli.py", line 104, in main
    run(args, config, args.start, args.end)
  File "/Users/paul.oflynn/workspace/venv/lib/python3.7/site-packages/cloudtracker/__init__.py", line 436, in run
    account_iam = get_account_iam(account)
  File "/Users/paul.oflynn/workspace/venv/lib/python3.7/site-packages/cloudtracker/__init__.py", line 162, in get_account_iam
    return json.load(open(account['iam']))
FileNotFoundError: [Errno 2] No such file or directory: 'account-data/demo-iam.json'```
poflynn commented 6 years ago

No doubt the cause of #23 also..

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Paul O'Flynn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

0xdabbad00 commented 6 years ago

Thank you for figuring that out and what was going on in #23! Can you agree to the CLA so I can accept this PR?

poflynn commented 6 years ago

Thank you for figuring that out and what was going on in #23! Can you agree to the CLA so I can accept this PR?

Hmm, I did sign it - twice in fact. When I click on the link now I get the msg "You have signed the CLA for duo-labs/cloudtracker". Not sure what else I can do?

0xdabbad00 commented 6 years ago

I think the username or email address used for your git commit doesn't match your Github account, so that's why the CLA check isn't passing. Since you've stated here that you signed it, that's good enough for me as a record that you signed it.

poflynn commented 6 years ago

Ack, indeed, wrong email which I didn't want. Oh well, merged now so too late.

Thx for the awesome utility...