search

duo-labs / cloudtracker

CloudTracker helps you find over-privileged IAM users and roles by comparing CloudTrail logs with current IAM policies.
BSD 3-Clause "New" or "Revised" License
887 stars 111 forks source link

Upgrade requirements #55

Closed nickolashkraus closed 4 years ago

nickolashkraus commented 5 years ago

Issue

I hit the following error when trying to install CloudTracker via pip:

$ python -V
Python 3.7.2

pip install cloudtracker
...
Building wheels for collected packages: pyyaml
  Building wheel for pyyaml (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /Users/nkraus/.virtualenvs/cloudtracker/bin/python3.7 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/sd/nmgrfczd6lq2j59x
jg7yc37j5ppjz1/T/pip-install-_fmp6z5a/pyyaml/setup.py'"'"'; __file__='"'"'/private/var/folders/sd/nmgrfczd6lq2j59xjg7yc37j5ppjz1/T/pip-install-_fmp6z5a/pyyaml/setup.p
y'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))
' bdist_wheel -d /private/var/folders/sd/nmgrfczd6lq2j59xjg7yc37j5ppjz1/T/pip-wheel-sq3f00_j --python-tag cp37
       cwd: /private/var/folders/sd/nmgrfczd6lq2j59xjg7yc37j5ppjz1/T/pip-install-_fmp6z5a/pyyaml/

Solution

Bumping the requirements seems to have fixed the issue:

$ pip install -e .
...
Successfully installed PyYAML-5.1.2 boto3-1.9.202 botocore-1.12.202 cloudtracker docutils-0.14 jmespath-0.9.4 s3transfer-0.2.1 urllib3-1.25.3

Testing

Ran Nosetests:

$ nosetests tests/unit/test_cloudtracker.py
...........
Name                       Stmts   Miss  Cover
----------------------------------------------
cloudtracker/__init__.py     271    129    52%
----------------------------------------------------------------------
Ran 11 tests in 0.229s

OK
CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.