duo-labs / py_webauthn

Pythonic WebAuthn 🐍
https://duo-labs.github.io/py_webauthn
BSD 3-Clause "New" or "Revised" License
856 stars 171 forks source link

examples/registration.py fails #118

Closed nikosft closed 2 years ago

nikosft commented 2 years ago

The script examples/registration.py fails with the following error

AttributeError: 'VerifiedRegistration' object has no attribute 'json'

I see that in older versions of the coder VerifiedRegistration was extending WebAuthnBaseModel which defines that method. Nevertheless, in the current version VerifiedRegistration does not extend any class.

MasterKale commented 2 years ago

Thank you for reporting this, @nikosft, it turns out I accidentally broke those when I released v1.2.0 🙃

I'm happy to report, though, that the switch back to Pydantic in #117 will fix the examples. I tested them all just now to be sure and they worked as expected! 🎉

I'll follow up when I finally merge and release #117.

MasterKale commented 2 years ago

@nikosft The examples should work again if you pull down the latest webauthn==1.3.0 :v: