search

duo-labs / py_webauthn

Pythonic WebAuthn 🐍
https://duo-labs.github.io/py_webauthn
BSD 3-Clause "New" or "Revised" License
856 stars 171 forks source link

some functions still throw pydantic.ValidationError #173

Closed jpaniagualaconich closed 9 months ago

jpaniagualaconich commented 1 year ago

public interface functions such as verify_authentication_response should not throw pydantic.ValidationError. There are exceptions defined in webauthn.helpers.exceptions that can be used to avoid depending on pydantic symbols.

MasterKale commented 11 months ago

Thanks for raising this @jpaniagualaconich, it would definitely be a good idea to abstract validation errors like this away. This can be undertaken as part of the effort that will fully migrate the project to Pydantic v2.

MasterKale commented 9 months ago

This may end up being closed out if I move forward with #195 as it would remove Pydantic as a dependency of this project.

MasterKale commented 9 months ago

I've merged #195 which removed Pydantic as a dependency of this project so I'm closing out any PR's and issues related to Pydantic as they're no longer needed.