login.html: Fix label for select-attestation

duo-labs / webauthn.io

The source code for webauthn.io, a demonstration of WebAuthn.

https://webauthn.io

BSD 3-Clause "New" or "Revised" License

645 stars 120 forks source link

login.html: Fix label for select-attestation #47

Closed jlduran closed 1 year ago

jlduran commented 2 years ago

Minor fix select-authenticator should be select-attestation for the "Attestation Type" label.

CLAassistant commented 2 years ago

All committers have signed the CLA.

jonesnl commented 2 years ago

This bug causes screen reader based users to not be able to accurately navigate the website. It would be nice to get this fixed if Duo expects to continue supporting webauthn.io as a demo platform for this technology.

edit: Looks like a rewrite is on the way, and on first glance the issue being fixed here is not present in the new PR: https://github.com/duo-labs/webauthn.io/pull/58/files. 👍

MasterKale commented 1 year ago

This particular change is no longer valid. Feel free to create a new issue/PR if I missed something and re-introduced this problem in the rewrite.