search

duo-labs / webauthn

WebAuthn (FIDO2) server library written in Go
https://webauthn.io/
BSD 3-Clause "New" or "Revised" License
1.03k stars 162 forks source link

build: update to Go 1.18 #116

Closed Juneezee closed 2 years ago

Juneezee commented 2 years ago

This PR introduces two changes:

  1. Updates the go directive in go.mod file by running go mod tidy -go=1.17 to enable module graph pruning and lazy module loading.
  2. Update GitHub Actions go.yml to Go 1.17

Note 1: This PR does not prevent users with earlier Go versions from successfully building packages from this module.

Note 2: The additional require directive is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.

nicksteele commented 2 years ago

👍

aseigler commented 2 years ago

Perhaps we bump this to 1.18 now that 1.17 is no longer supported and try to get it merged?

Juneezee commented 2 years ago

@aseigler Updated to Go 1.18. Please take a look again, thank you :smiley:

aseigler commented 2 years ago

I think this is ready to merge @MasterKale unless anyone has objections? This is what is breaking actions currently.

MasterKale commented 2 years ago

I just first-time contributor actions, I think those have to run? Mobile doesn't show that real well so I'll check later today when I get back in front of a computer. If everything looks fine there I'll merge.

MasterKale commented 2 years ago

Merging despite test failures, it's @aseigler's fault if it breaks a bunch of stuff (and mine if it fixes them all) :shipit: