Fix TPMS_ECC_POINT parsing for TPM attestation with ECC key

duo-labs / webauthn

WebAuthn (FIDO2) server library written in Go

https://webauthn.io/

BSD 3-Clause "New" or "Revised" License

1.03k stars 162 forks source link

Fix TPMS_ECC_POINT parsing for TPM attestation with ECC key #145

Closed aseigler closed 2 years ago

aseigler commented 2 years ago

Add COSE elliptic curve constants
Add map for COSE elliptic curve to TPM elliptic curve values
Properly compare curve value from pubArea to curve from credentialPublicKey
Add test for TPM attestation when ECC key is utilized

aseigler commented 2 years ago

That's not a bad idea. I can't see why we could ever need to do that import. In fact, I am struggling to recall why I grabbed just the tiny pieces for googletpm instead of just importing the go-tpm package and using that.

MasterKale commented 2 years ago

@james-d-elliott Would you like to give the most recent changes a once-over and approve/review accordingly?