search

duojs / duo

A next-generation package manager for the front-end
3.42k stars 118 forks source link

plugin entry should probably just be parent #364

Open matthewmueller opened 9 years ago

matthewmueller commented 9 years ago

Not 100% sure if there's repercussions here, but I'm thinking entry should be parent

Instead of: 

function *plugin(file, entry) {

}

it should probably be:

function *plugin(file, parent) {

}

The use case I'm running into is supporting HTML that have javascript, the plugins will think entry.type will be HTML, though for all real purposes, the plugin context will be javascript.