duojs / duo

A next-generation package manager for the front-end
3.42k stars 118 forks source link

resolves some incorrect paths #376

Open azhang opened 9 years ago

azhang commented 9 years ago

Notice how for the "backbone" dependency, it loads the incorrect path (backbone resolves to backbone.babysitter).

https://github.com/marionettejs/backbone.marionette/blob/master/package.json:

  "dependencies": {
    "backbone.babysitter": "^0.1.0",
    "backbone.wreqr": "^1.0.0",
    "backbone": "1.0.0 - 1.1.2",
    "underscore": "1.4.4 - 1.6.0"
  },

In my duo.json:

  "components/marionettejs-backbone.marionette@v2.2.2/lib/core/backbone.marionette.js": {
    "id": "components/marionettejs-backbone.marionette@v2.2.2/lib/core/backbone.marionette.js",
    "type": "js",
    "mtime": 1414006941000,
    "src": [...]
    "deps": {
      "backbone": "components/marionettejs-backbone.babysitter@v0.1.5/lib/backbone.babysitter.js",
      "underscore": "components/jashkenas-underscore@1.7.0/underscore.js",
      "backbone.wreqr": "components/marionettejs-backbone.wreqr@v1.3.1/lib/backbone.wreqr.js",
      "backbone.babysitter": "components/marionettejs-backbone.babysitter@v0.1.5/lib/backbone.babysitter.js"
    }
matthewmueller commented 9 years ago

duo uses a component.json and not a package.json to resolve dependencies that it cannot resolve from the source.

azhang commented 9 years ago

It specifies the correct github repo in component.json as well, I think?

https://github.com/marionettejs/backbone.marionette/blob/master/component.json

  "dependencies": {
    "marionettejs/backbone.babysitter": "*",
    "marionettejs/backbone.wreqr": "*",
    "jashkenas/backbone": "*",
    "jashkenas/underscore": "*"
  },