search

duojs / duo

A next-generation package manager for the front-end
3.42k stars 118 forks source link

Adding local vs remote guard for files #404

Closed dominicbarnes closed 9 years ago

dominicbarnes commented 9 years ago

This adds File#local() and File#remote() as guards/hooks for plugins primarily. After toying around with this for a while, it seemed like this was the least intrusive way to add the feature. (a little hacky, but it works)

(this will fix #402)

matthewmueller commented 9 years ago

LGTM!

dominicbarnes commented 9 years ago

Ok guys, take a look again. I've made this code a lot more robust using this.installTo(), path.sep and a much more reliable test.

dominicbarnes commented 9 years ago

@stephenmathieson I just added a test for installTo("not components") as well to be certain! :)

stephenmathieson commented 9 years ago

lgtm!