duojs / duo

A next-generation package manager for the front-end
3.42k stars 118 forks source link

Consider dropping the hard gnode dependency #448

Closed dominicbarnes closed 9 years ago

dominicbarnes commented 9 years ago

In response to #433 and #445, I think it's time to consider dropping gnode throughout the duo libs:

matthewmueller commented 9 years ago

+1 i'm fine with this

dominicbarnes commented 9 years ago

I'm going to push forward on this soon, it seems like lots of weird edge-cases are cropping up because of gnode/regenerator. (and with people using node 0.12 more often, the errors mentioned here really obscure the fact that the --harmony-generators flag was left out)

matthewmueller commented 9 years ago

sgtm!

stephenmathieson commented 9 years ago

+1 from me, but unfortunately, a lot of my team is still using node 0.10... and it's what we've got in production.

i'll either get people to move to iojs/node 0.12, or try to hack something together on my end using gnode.

dominicbarnes commented 9 years ago

@stephenmathieson yeah, my team still has node 0.10 around as well. (though we're using 0.11 more often) Thankfully, all you need to do if you know you're using node 0.10 is to add gnode to your build command. (you guys use make right?)

stephenmathieson commented 9 years ago

yep, we'll just:

build.js: ...
  $(BIN)/gnode $(BIN)/_duo ...
dominicbarnes commented 9 years ago

The last dependency including gnode is duo-test, but since that's a sub-command it doesn't affect duo core anymore.