search

duojs / duo

A next-generation package manager for the front-end
3.42k stars 118 forks source link

Adding ESLint #472

Closed dominicbarnes closed 9 years ago

dominicbarnes commented 9 years ago

This adds ESLint to our build process, not required by any means, but there for devs to use and fix issues with.

The config is totally open to changes, I've tried to respect the original code style here and just enforce some consistency. The primary goal here is to include things like no-unused-vars to try and weed out unnecessary requires and optimize things generally.

stephenmathieson commented 9 years ago

lgtm

matthewmueller commented 9 years ago

+1, I've started using: http://github.com/feross/standard, but this is probably less work.

dominicbarnes commented 9 years ago

I'm open to adopting standard instead of ESLint, what do you guys think?

dominicbarnes commented 9 years ago

Haha, turns out the standard itself uses ESLint under the hood. I'll go ahead and merge this now, we can switch to standard at any time. (it already throws a lot of errors about semi-colons, so it will be a lot of small changes to make all at once)