duojs / duo

A next-generation package manager for the front-end
3.42k stars 118 forks source link

Properly respond to a modified manifest file #487

Closed dominicbarnes closed 9 years ago

dominicbarnes commented 9 years ago

Currently, if you change a version in your manifest file, it will only update the dependency when you:

This causes headaches when using a manifest for managing versions in your project, because only the first 2 options end up being viable in practice. Not only that, but in a CI environment, you can't reliably cache the components directory, because it will not remain up-to-date for the same reasons.

This changes the internal behavior and makes a modified manifest invalidate the cache for individual files. (causing it to re-resolve the dependencies) A lot of the caching work I've been doing makes this a reliable action to take. (and will hit the API far fewer times than having to re-resolve everything after destroying the cache)

stephenmathieson commented 9 years ago

lgtm!

dominicbarnes commented 9 years ago

Sweet! I'm going to make one other PR sometime today in this same vein. It should be the last piece to efficiently using Duo in CI. :)

stephenmathieson commented 9 years ago

awesome!