duolicious / duolicious-frontend

The frontend of the Duolicious dating app
https://duolicious.app/
GNU Affero General Public License v3.0
32 stars 12 forks source link

#237 Add option 'maybe' to 'wants kids' #300

Closed gonnaduobitofhelping closed 1 month ago

gonnaduobitofhelping commented 1 month ago

I went with "Maybe" instead of "Not sure" since that already existed in the codebase, but if it has to be specifically "Not sure", I could do the mapping in the frontend.

duogenesis commented 1 month ago

I think the backend will need to be modified before this change can be merged. POSTing anything other than Yes or No should currently return a HTTP 4xx error

gonnaduobitofhelping commented 1 month ago

It actually doesn't seem like it, wants_kids references the yes_no_maybe table and there doesn't seem to be any additional validation since it saves just fine when I'm testing it locally. I initially tried naming the option "Not sure" and that did indeed not work.

duogenesis commented 1 month ago

It's a bit worrying that the frontend and backend don't match up, but good that it makes this change easier. Do the search options work with Maybe too?

On Fri, 24 May 2024 at 06:19, gonnaduobitofhelping @.***> wrote:

It actually doesn't seem like it, wants_kids references the yes_no_maybe table and there doesn't seem to be any additional validation since it saves just fine when I'm testing it locally. I initially tried naming the option "Not sure" and that did indeed not work.

— Reply to this email directly, view it on GitHub https://github.com/duolicious/duolicious-frontend/pull/300#issuecomment-2127951666, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAQONZOYFMKUVINNLSNEHI3ZDZFL7AVCNFSM6AAAAABIGKFZ2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHE2TCNRWGY . You are receiving this because you commented.Message ID: @.***>

gonnaduobitofhelping commented 1 month ago

I didn't test that bit before, but yes, that also works.

It's a bit worrying that the frontend and backend don't match up, but good that it makes this change easier. Do the search options work with Maybe too? On Fri, 24 May 2024 at 06:19, gonnaduobitofhelping @.> wrote: It actually doesn't seem like it, wants_kids references the yes_no_maybe table and there doesn't seem to be any additional validation since it saves just fine when I'm testing it locally. I initially tried naming the option "Not sure" and that did indeed not work. — Reply to this email directly, view it on GitHub <#300 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAQONZOYFMKUVINNLSNEHI3ZDZFL7AVCNFSM6AAAAABIGKFZ2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHE2TCNRWGY . You are receiving this because you commented.Message ID: @.>